perf(system_tags): Optimize system tag activity recipient resolution for file mapper events#59931
perf(system_tags): Optimize system tag activity recipient resolution for file mapper events#59931mosi-kha wants to merge 1 commit into
Conversation
…ng redundant calls and improving node resolution logic
|
@ArtificialOwl @icewind1991 @nfebe @sorbaugh |
|
Conflict a bit with #58602 |
If your PR is accepted, should I apply changes to TagListener, right? |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
systemtagsactivity handling forMapperEvent::EVENT_ASSIGN/EVENT_UNASSIGNcurrently resolves recipients by iterating all mounts returned bygetMountsForFileId()and repeatedly callinggetPathsForAccessList()for the same file event.Listener::mapperEvent()because access-list expansion is recomputed many times.getPathsForAccessList()once, and reuses that user-path map for activity publishing.Problem
mapperEvent()did per-mount:getPathsForAccessList(node)getPathsForAccessList()already performs access-list expansion for the file node, so per-mount repetition is redundant and scales poorly with mount count.Solution
$node->getOwner()+ ownergetById()), to use canonical share/access context.getPathsForAccessList()once, assign$users = $al['users'], and stop iterating.Why this is safe
filesobject type, non-empty tags, assign/unassign events, activity app enabled).updateLastUsedTagsbehavior).Performance impact (measured example)
Test plan
Notes for reviewers
getPathsForAccessList()call is sufficient.